Ticket #89 (closed enhancement: fixed)

Opened 4 years ago

Last modified 12 months ago

RSS feed for comments

Reported by: mike Owned by: sidtheduck
Priority: high Milestone: 1.0
Component: RSS Version: 1.0b3
Severity: normal Keywords:
Cc: tracs@…

Description

Create an additional RSS feed for individual picture comments.

Attachments

rss_picture_comments.patch Download (5.7 KB) - added by sidtheduck 20 months ago.
Code to add picture comment support

Change History

  Changed 4 years ago by anonymous

  • priority changed from normal to high

follow-up: ↓ 6   Changed 21 months ago by dime

  • cc tracs@… added
  • component changed from General to RSS

This should be done, and removing current feed that appears in meta tags with cruft-free URLs turned on, on single-picture pages, which shows nothing but one picture, and only can create confusion and more used bandwith.

  Changed 20 months ago by sidtheduck

  • milestone set to 1.1

If I find some time, I may be able to get to this for 1.0, but I'll put it under 1.1 for the time being. Should be easy enough to manage.

Changed 20 months ago by sidtheduck

Code to add picture comment support

follow-up: ↓ 5   Changed 20 months ago by sidtheduck

  • keywords has-patch needs-testing 2nd-opinion added

I added some quick code to the plog-rss.php file for single picture comment support. You can test out the patch to r569 that I've attached to this ticket. It fully validates for my test gallery rss feed.

Basically I'm looking for some feedback. Currently, it still shows the picture (just like a standard rss feed for an album or collection), but then adds the comments below it (in reverse order). If there are no comments, it just shows the single image by itself.

What I'm wondering is if we want to have the image in there or just the comments by themselves. If the image stays, do we want the description, etc. or just the image by itself. If there are no comments, should it display "No comments" much like regular front-end comments?

I also need to add code to not display the RSS feed link or button and not to display the RSS comments if comments are turned off by the user, but I wanted to get this out there to get feedback on how to better implement it.

in reply to: ↑ 4   Changed 20 months ago by kimparsell

  • owner changed from mike to sidtheduck

Replying to sidtheduck:

I added some quick code to the plog-rss.php file for single picture comment support. You can test out the patch to r569 that I've attached to this ticket. It fully validates for my test gallery rss feed.

I checked and the comments feed validates on my test gallery as well.

Basically I'm looking for some feedback. Currently, it still shows the picture (just like a standard rss feed for an album or collection), but then adds the comments below it (in reverse order). If there are no comments, it just shows the single image by itself. What I'm wondering is if we want to have the image in there or just the comments by themselves. If the image stays, do we want the description, etc. or just the image by itself. If there are no comments, should it display "No comments" much like regular front-end comments?

I would include the image in the feed, along with the description (if any). With regard to whether to display "no comments", my concern there is that we would display it initially before any comments had been added, but how will you remove it once a comment has been posted for that image? It could be confusing to see "no comments" and a list of comments directly under it.

I also need to add code to not display the RSS feed link or button and not to display the RSS comments if comments are turned off by the user, but I wanted to get this out there to get feedback on how to better implement it.

With this current patch, the rss image is not being displayed in the footer of the page, only in the address bar. If implemented, the rss feed image will need to show in the footer as well if comments are turned on. You will also need to add code to ensure that any comments in the moderation queue are not shown in the feed until they are approved.

in reply to: ↑ 2   Changed 20 months ago by sidtheduck

Replying to kimparsell:

I would include the image in the feed, along with the description (if any). With regard to whether to display "no comments", my concern there is that we would display it initially before any comments had been added, but how will you remove it once a comment has been posted for that image? It could be confusing to see "no comments" and a list of comments directly under it.

Replying to dime:

... which shows nothing but one picture, and only can create confusion and more used bandwith.

I was mostly bringing up the "No comments" or no image in the feed if there are no comments because of dime's post above saying that it could cause confusion and waste bandwidth. I would agree with the confusion part if there are no comments and it is just a single image posted. Should I have it only display the image if comments are present and if not, just post a blank RSS feed?

Replying to kimparsell:

With this current patch, the rss image is not being displayed in the footer of the page, only in the address bar. If implemented, the rss feed image will need to show in the footer as well if comments are turned on. You will also need to add code to ensure that any comments in the moderation queue are not shown in the feed until they are approved.

Yep, this is what I was talking about. I need to add the code to show the rss feed button and link if comments are turned on as well as put safeguards in the rss feed code itself to only display if comments are turned on (in case someone has a direct link to the rss feed even after comments have been turned off).

Comments in the moderation queue ahould already taken care of with the current code as well as it uses the same comment loop as the front-end gallery.

  Changed 19 months ago by sidtheduck

  • status changed from new to assigned

The RSS code is fixed for pictures with no comments. All that's left is the RSS feed link and RSS feed button.

  Changed 19 months ago by ryanduff

  • keywords has-patch needs-testing 2nd-opinion removed
  • status changed from assigned to testing

  Changed 15 months ago by kimparsell

  • milestone changed from 1.1 to 1.0

  Changed 13 months ago by kimparsell

In rev590, mages with no comments are not showing the RSS link in the footer of the page, nor in the address bar, so I am unable to subscribe to them. Images that do have at least 1 approved comment show the RSS link in the footer and address bar.

Are we going to try and get this included in the next release?

  Changed 13 months ago by sidtheduck

What else needs to be implemented / included? What you described is exactly the code I included to make it work properly (AFAIK). Is there a different functionality you were looking for, kimparsell?

  Changed 13 months ago by kimparsell

  • status changed from testing to commit
  • type changed from defect to enhancement

Then I guess it's working as it is intended to: images with at least 1 comment will show the feed button at the bottom of the page and in the address bar. Images with no comments will show neither of them.

I was under the assumption that you could subscribe to the comments for an image regardless of whether it already had a comment or not. After re-reading the conversation above, I see that my assumption was incorrect.

I think we can close this ticket now.

  Changed 12 months ago by kimparsell

  • status changed from commit to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.